enhancement/Issue-1087: Upgrade Rollup to latest 3.x.x #1187
Conversation
DevLab2425
changed the title
thescientist13
added
enhancement
|
Now that #1190 has been merged, I would rebase this branch against master to help clear up any related test failures. |
thescientist13
force-pushed
the
issue-1087-update-rollup-and-friends
branch
from
3412194
to
061bb50
Compare
|
Had a little time to circle back on this and was able to rebase and get all the test cases passing along with updating any Rollup dependencies used in our other packages. There does seem to be one issue though, in that a production build of the website is missing a script file reference for the Get Started button on the home page and a 404 on the script asset (though interestingly there is a 756510913.js in the .greenwood/ folder, where assets are collected prior to final bundling 🤔 )
As opposed to what it should look like Will see if there is anything of note in the Rollup v3 changelog and start taking a look, but we're almost this almost there! |
|
Got if fixed, I think duplicate imports of the |
thescientist13
changed the title
thescientist13
force-pushed
the
issue-1087-update-rollup-and-friends
branch
from
21392b6
to
4081f23
Compare
* Issue-1087: Initial upgrade of Rollup and @rollup plugins * Issue-1087: Upgrade plugin dependencies * upgrade all test cases with new hash matchers * update all plugin rollup deps and breaking change updates * fix duplicate imports of eve-container custom element definition --------- Co-authored-by: Owen Buckley <owenbuckley13@gmail.com>
* Issue-1087: Initial upgrade of Rollup and @rollup plugins * Issue-1087: Upgrade plugin dependencies * upgrade all test cases with new hash matchers * update all plugin rollup deps and breaking change updates * fix duplicate imports of eve-container custom element definition --------- Co-authored-by: Owen Buckley <owenbuckley13@gmail.com>
Related Issue
Fix: #1087
Summary of Changes
yarn upgradeforrollupin the CLIThe collection of@rollup/packages supportrollup@3.x.x. Ayarn upgradewas run, but there was no impact to the current lockfile for those dependencies.TODO